Re: [PATCH 5.15 067/356] selftests/mm: log a consistent test name for check_compaction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 03, 2024 at 02:52:14PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 03, 2024 at 01:02:18PM +0100, Mark Brown wrote:
> > On Wed, Jul 03, 2024 at 12:36:43PM +0200, Greg Kroah-Hartman wrote:

> > > Refactor the logging to use a consistent name when printing the result of
> > > the test, printing the existing messages as diagnostic information instead
> > > so they are still available for people trying to interpret the results.

> > I'm not convinced that this is a good stable candidate, it will change
> > the output people are seeing in their test environment which might be an
> > undesirable change.

> Did it change the output in a breaking way in the other stable trees and
> normal releases that happened with this commit in it?

Yes, it'd affect other releases - I didn't notice it going into other
stables (I tend to review the AUTOSEL stuff a lot more carefully than
things you send out since you normally only pick things that are Cc
stable but AUTOSEL has some wild stuff).  The output tended to be stable
for a given test setup so it's likely that if you're just looking for
the same test results in a stable release you'd see these tests getting
renamed on you.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux