Re: [PATCH 4.19 093/139] scsi: mpt3sas: Add ioc_<level> logging macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2024-07-03 at 12:39 +0200, Greg Kroah-Hartman wrote:
> 4.19-stable review patch.  If anyone has any objections, please let me know.

Still think this isn't necessary.

see: https://lore.kernel.org/stable/Zn25eTIrGAKneEm_@sashalap/

> 
> ------------------
> 
> From: Joe Perches <joe@xxxxxxxxxxx>
> 
> [ Upstream commit 645a20c6821cd1ab58af8a1f99659e619c216efd ]
> 
> These macros can help identify specific logging uses and eventually perhaps
> reduce object sizes.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> Acked-by: Suganath Prabu <suganath-prabu.subramani@xxxxxxxxxxxx>
> Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Stable-dep-of: 4254dfeda82f ("scsi: mpt3sas: Avoid test/set_bit() operating in non-allocated memory")
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h
> index 96dc15e90bd83..941a4faf20be0 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.h
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h
> @@ -160,6 +160,15 @@ struct mpt3sas_nvme_cmd {
>   */
>  #define MPT3SAS_FMT			"%s: "
>  
> +#define ioc_err(ioc, fmt, ...)						\
> +	pr_err("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +#define ioc_notice(ioc, fmt, ...)					\
> +	pr_notice("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +#define ioc_warn(ioc, fmt, ...)						\
> +	pr_warn("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +#define ioc_info(ioc, fmt, ...)						\
> +	pr_info("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +
>  /*
>   *  WarpDrive Specific Log codes
>   */






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux