On Mon, Jul 01, 2024 at 07:57:53PM +0000, Igor Pylypiv wrote: > SAT-5 revision 8 specification removed the text about the ANSI INCITS > 431-2007 compliance which was requiring SCSI/ATA Translation (SAT) to > return descriptor format sense data for the ATA PASS-THROUGH commands > regardless of the setting of the D_SENSE bit. > > Let's honour the D_SENSE bit for CK_COND=1 commands that had no error. > Kernel already honours the D_SENSE bit when creating the sense buffer > for commands that had an error. Nit: we also honor it when creating the sense buffer for successful NCQ commands (e.g. CDL policy 0xD). > > SAT-5 revision 7 > ================ > > 12.2.2.8 Fixed format sense data > > Table 212 shows the fields returned in the fixed format sense data > (see SPC-5) for ATA PASS-THROUGH commands. SATLs compliant with ANSI > INCITS 431-2007, SCSI/ATA Translation (SAT) return descriptor format > sense data for the ATA PASS-THROUGH commands regardless of the setting > of the D_SENSE bit. > > SAT-5 revision 8 > ================ > > 12.2.2.8 Fixed format sense data > > Table 211 shows the fields returned in the fixed format sense data > (see SPC-5) for ATA PASS-THROUGH commands. > > Cc: stable@xxxxxxxxxxxxxxx # 4.19+ > Reported-by: Niklas Cassel <cassel@xxxxxxxxxx> > Closes: https://lore.kernel.org/linux-ide/Zn1WUhmLglM4iais@xxxxxxxxx > Signed-off-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx> > --- > drivers/ata/libata-scsi.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index 26b1263f5c7c..ace6b009e7ff 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -941,11 +941,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) > &sense_key, &asc, &ascq); > ata_scsi_set_sense(qc->dev, cmd, sense_key, asc, ascq); > } else { > - /* > - * ATA PASS-THROUGH INFORMATION AVAILABLE > - * Always in descriptor format sense. > - */ > - scsi_build_sense(cmd, 1, RECOVERED_ERROR, 0, 0x1D); > + /* ATA PASS-THROUGH INFORMATION AVAILABLE */ > + ata_scsi_set_sense(qc->dev, cmd, RECOVERED_ERROR, 0, 0x1D); > } > } > > -- > 2.45.2.803.g4e1b14247a-goog > With or without nit fixed: Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
