This is a note to let you know that I've just added the patch titled USB: cdc-acm: check for valid interfaces to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-cdc-acm-check-for-valid-interfaces.patch and it can be found in the queue-3.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 403dff4e2c94f275e24fd85f40b2732ffec268a1 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Fri, 7 Nov 2014 08:48:15 -0800 Subject: USB: cdc-acm: check for valid interfaces From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> commit 403dff4e2c94f275e24fd85f40b2732ffec268a1 upstream. We need to check that we have both a valid data and control inteface for both types of headers (union and not union.) References: https://bugzilla.kernel.org/show_bug.cgi?id=83551 Reported-by: Simon Schubert <2+kernel@xxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/usb/class/cdc-acm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1197,10 +1197,11 @@ next_desc: } else { control_interface = usb_ifnum_to_if(usb_dev, union_header->bMasterInterface0); data_interface = usb_ifnum_to_if(usb_dev, (data_interface_num = union_header->bSlaveInterface0)); - if (!control_interface || !data_interface) { - dev_dbg(&intf->dev, "no interfaces\n"); - return -ENODEV; - } + } + + if (!control_interface || !data_interface) { + dev_dbg(&intf->dev, "no interfaces\n"); + return -ENODEV; } if (data_interface_num != call_interface_num) Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-3.18/asoc-tlv320aic31xx-fix-off-by-one-error-in-the-loop-stucture.patch queue-3.18/kvm-x86-em_ret_far-overrides-cpl.patch queue-3.18/alsa-fireworks-fix-an-endianness-bug-for-transaction-length.patch queue-3.18/x86-export-get_xsave_addr.patch queue-3.18/rtc-omap-fix-missing-wakealarm-attribute.patch queue-3.18/hid-wacom-fix-freeze-on-open-when-autosuspend-is-on.patch queue-3.18/kvm-x86-support-xsaves-usage-in-the-host.patch queue-3.18/hid-add-battery-quirk-for-usb_device_id_apple_alu_wireless_2011_iso-keyboard.patch queue-3.18/asoc-sigmadsp-refuse-to-load-firmware-files-with-a-non-supported-version.patch queue-3.18/bluetooth-fix-accepting-connections-when-not-using-mgmt.patch queue-3.18/bluetooth-fix-le-connection-timeout-deadlock.patch queue-3.18/x86-vdso-use-asm-volatile-in-__getcpu.patch queue-3.18/alsa-hda-using-uninitialized-data.patch queue-3.18/ktest-fix-make_min_config-to-handle-new-assign_configs-call.patch queue-3.18/asoc-dwc-ensure-fifos-are-flushed-to-prevent-channel-swap.patch queue-3.18/hid-i2c-hid-prevent-buffer-overflow-in-early-irq.patch queue-3.18/drivers-rtc-rtc-sirfsoc.c-move-hardware-initilization-earlier-in-probe.patch queue-3.18/can-peak_usb-fix-memset-usage.patch queue-3.18/pstore-ram-allow-optional-mapping-with-pgprot_noncached.patch queue-3.18/powerpc-perf-hv-24x7-use-per-cpu-page-buffer.patch queue-3.18/alsa-usb-audio-extend-kef-x300a-fu-10-tweak-to-arcam-rpac.patch queue-3.18/kvm-s390-fix-ipte-locking.patch queue-3.18/asoc-pcm512x-trigger-auto-increment-of-register-addresses-on-i2c.patch queue-3.18/kvm-s390-fix-size-of-monitor-class-number-field.patch queue-3.18/rtc-omap-fix-clock-source-configuration.patch queue-3.18/blk-mq-use-nr_cpu_ids-as-highest-cpu-id-count-for-hwq-cpu-map.patch queue-3.18/kvm-x86-drop-severity-of-generation-wraparound-message.patch queue-3.18/hid-roccat-potential-out-of-bounds-in-pyra_sysfs_write_settings.patch queue-3.18/bluetooth-6lowpan-fix-skb_unshare-behaviour.patch queue-3.18/bluetooth-ath3k-add-support-of-mci-13d3-3408-bt-device.patch queue-3.18/powerpc-fix-bad-null-pointer-check-in-udbg_uart_getc_poll.patch queue-3.18/hid-i2c-hid-do-not-free-buffers-in-i2c_hid_stop.patch queue-3.18/misc-genwqe-check-for-error-from-get_user_pages_fast.patch queue-3.18/alsa-hda-add-new-gpu-codec-id-0x10de0072-to-snd-hda.patch queue-3.18/ocfs2-fix-the-wrong-directory-passed-to-ocfs2_lookup_ino_from_name-when-link-file.patch queue-3.18/kvm-x86-mask-out-xsaves.patch queue-3.18/iwlwifi-dvm-fix-flush-support-for-old-firmware.patch queue-3.18/md-raid5-fetch_block-must-fetch-all-the-blocks-handle_stripe_dirtying-wants.patch queue-3.18/drivers-rtc-rtc-isl12057.c-fix-masking-of-register-values.patch queue-3.18/alsa-hda-realtek-new-codec-support-for-alc256.patch queue-3.18/i8k-add-support-for-dell-latitude-e6440.patch queue-3.18/asoc-max98090-fix-ill-defined-sidetone-route.patch queue-3.18/pci-restore-detection-of-read-only-bars.patch queue-3.18/swiotlb-xen-pass-dev_addr-to-swiotlb_tbl_unmap_single.patch queue-3.18/alsa-hda-realtek-new-codec-support-for-alc298.patch queue-3.18/bluetooth-fix-controller-configuration-with-hci_quirk_invalid_bdaddr.patch queue-3.18/usb-gadget-at91_udc-move-prepare-clk-into-process-context.patch queue-3.18/hid-i2c-hid-fix-race-condition-reading-reports.patch queue-3.18/hid-yet-another-buggy-elan-touchscreen.patch queue-3.18/ocfs2-fix-journal-commit-deadlock.patch queue-3.18/pstore-ram-fix-hangs-by-using-write-combine-mappings.patch queue-3.18/iwlwifi-add-new-device-ids-for-3165.patch queue-3.18/ath9k_hw-fix-hardware-queue-allocation.patch queue-3.18/iommu-vt-d-fix-dmar_domain-leak-in-iommu_attach_device.patch queue-3.18/ath5k-fix-hardware-queue-index-assignment.patch queue-3.18/usb-qcserial-add-support-for-hp-lt4112-lte-hspa-gobi-4g-modem.patch queue-3.18/blk-mq-fix-uninitialized-kobject-at-cpu-hotplugging.patch queue-3.18/i2c-designware-fix-falling-time-bindings-doc.patch queue-3.18/swiotlb-xen-call-xen_dma_sync_single_for_device-when-appropriate.patch queue-3.18/asoc-eukrea-tlv320-fix-of_node_put-call-with-uninitialized-object.patch queue-3.18/ath9k-fix-be-bk-queue-order.patch queue-3.18/swiotlb-xen-remove-bug_on-in-xen_bus_to_phys.patch queue-3.18/iommu-vt-d-fix-an-off-by-one-bug-in-__domain_mapping.patch queue-3.18/alsa-snd-usb-caiaq-fix-stream-count-check.patch queue-3.18/usb-cdc-acm-check-for-valid-interfaces.patch queue-3.18/blk-mq-fix-a-use-after-free.patch queue-3.18/add-usb_ehci_exynos-to-multi_v7_defconfig.patch queue-3.18/brcmfmac-fix-ifidx-for-rx-data-by-msgbuf.patch queue-3.18/bluetooth-fix-check-for-direct-advertising.patch queue-3.18/blk-mq-avoid-that-__bt_get_word-wraps-multiple-times.patch queue-3.18/hid-add-a-new-id-0x501a-for-genius-mousepen-i608x.patch queue-3.18/ubi-fix-invalid-vfree.patch queue-3.18/powerpc-powernv-switch-off-mmu-before-entering-nap-sleep-rvwinkle-mode.patch queue-3.18/usb-renesas_usbhs-gadget-fix-null-pointer-dereference-in-ep_disable.patch queue-3.18/powerpc-add-little-endian-flag-to-syscall_get_arch.patch queue-3.18/hid-wacom-re-add-accidentally-dropped-lenovo-pid.patch queue-3.18/driver-core-fix-unbalanced-device-reference-in-drivers_probe.patch queue-3.18/x86_64-vdso-fix-the-vdso-address-randomization-algorithm.patch queue-3.18/can-peak_usb-fix-cleanup-sequence-order-in-case-of-error-during-init.patch queue-3.18/alsa-hda-realtek-add-new-dell-desktop-for-alc3234-headset-mode.patch queue-3.18/swiotlb-xen-pass-dev_addr-to-xen_dma_unmap_page-and-xen_dma_sync_single_for_cpu.patch queue-3.18/powerpc-book3s-fix-partial-invalidation-of-tlbs-in-mce-code.patch queue-3.18/blk-mq-fix-a-race-between-bt_clear_tag-and-bt_get.patch queue-3.18/alsa-hda-fix-wrong-gpio_dir-gpio_mask-hint-setups-for-idt-stac-codecs.patch queue-3.18/iwlwifi-mvm-update-values-for-smart-fifo.patch queue-3.18/ubi-fix-double-free-after-do_sync_erase.patch queue-3.18/kvm-s390-flush-cpu-on-load-control.patch queue-3.18/bluetooth-clear-le-white-list-when-resetting-controller.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html