Re: [PATCH] ata: libata-core: Add ATA_HORKAGE_NOLPM for all Crucial BX SSD1 models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 25, 2024 at 06:47:32AM +0900, Damien Le Moal wrote:
> On 2024/06/24 22:27, Niklas Cassel wrote:
> > We got another report that CT1000BX500SSD1 does not work with LPM.
> > 
> > If you look in libata-core.c, we have six different Crucial devices that
> > are marked with ATA_HORKAGE_NOLPM. This model would have been the seventh.
> > (This quirk is used on Crucial models starting with both CT* and
> > Crucial_CT*)
> > 
> > It is obvious that this vendor does not have a great history of supporting
> > LPM properly, therefore, add the ATA_HORKAGE_NOLPM quirk for all Crucial
> > BX SSD1 models.
> > 
> > Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reported-by: Tkd-Alex <alex.tkd.alex@xxxxxxxxx>
> 
> We need a real full name here, not a user name... So if Alex is not willing to
> send his full name, please remove this.

I disagree.

The Signed-off-by tag needs a real name, but if you take a dig through the
git log, you will see that the Reported-by tag is not always a real name.

E.g. the benevolent dictator for life used a non-real name for Reported-by
here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6022f210461fef67e6e676fd8544ca02d1bcfa7a

Anyway, now when we have a real name, I will send a V2.


Kind regards,
Niklas




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux