On Tue, Jun 25, 2024 at 08:55:44AM +1000, NeilBrown wrote: > On Mon, 24 Jun 2024, stable@xxxxxxxxxxxxxxx wrote: > > This is a note to let you know that I've just added the patch titled > > > > nfsd: fix oops when reading pool_stats before server is started > > > > to the 6.9-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > nfsd-fix-oops-when-reading-pool_stats-before-server-.patch > > and it can be found in the queue-6.9 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > I feel this should not be added to the stable tree. > > It moves at test on a field protected by a mutex outside of the > protection of that mutex, and so is obviously racey. > > Depending on how the race goes, si->serv might be NULL when dereferenced > in svc_pool_stats_start(), or svc_pool_stats_stop() might unlock a mutex > that hadn't been locked. > > I'll post a revert and a better fix for mainline. Now dropped, thanks! greg k-h