Hi Greg, On Mon, Jun 24, 2024 at 09:05:59AM +0200, Greg KH wrote: > On Mon, Jun 24, 2024 at 02:44:18PM +0800, Chun-Yi Lee wrote: > > For fixing CVE-2023-6270, f98364e92662 ("aoe: fix the potential > > use-after-free problem in aoecmd_cfg_pkts") makes tx() calling dev_put() > > instead of doing in aoecmd_cfg_pkts(). It avoids that the tx() runs > > into use-after-free. > > > > Then Nicolai Stange found more places in aoe have potential use-after-free > > problem with tx(). e.g. revalidate(), aoecmd_ata_rw(), resend(), probe() > > and aoecmd_cfg_rsp(). Those functions also use aoenet_xmit() to push > > packet to tx queue. So they should also use dev_hold() to increase the > > refcnt of skb->dev. > > > > Link: https://nvd.nist.gov/vuln/detail/CVE-2023-6270 > > Fixes: f98364e92662 ("aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts") > > Reported-by: Nicolai Stange <nstange@xxxxxxxx> > > Signed-off-by: Chun-Yi Lee <jlee@xxxxxxxx> > > --- > > <formletter> > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. > > </formletter> Thanks for your reminder. I will remove stable@xxxxxxxxxxxxxxx in next version. Joey Lee