Re: [PATCHv2 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 18, 2024 at 03:53:03PM +0800, Po-Hsu Lin wrote:
> Since upstream commit:
>   * 0f4765d0 "selftests/net: convert unicast_extensions.sh to run it in
>     unique namespace"
>   * 378f082e "selftests/net: convert pmtu.sh to run it in unique namespace"
> 
> The lib.sh from commit 25ae948b "selftests/net: add lib.sh" will be needed.
> Otherwise these test will complain about missing files and fail:
> $ sudo ./unicast_extensions.sh
> ./unicast_extensions.sh: line 31: lib.sh: No such file or directory
> ...
> 
> $ sudo ./pmtu.sh
> ./pmtu.sh: line 201: lib.sh: No such file or directory
> ./pmtu.sh: line 941: cleanup_all_ns: command not found
> ...
> 
> Another commit b6925b4e "selftests/net: add variable NS_LIST for lib.sh" is
> needed to add support for the cleanup_all_ns above.
> 
> And 2114e833 "selftests: forwarding: Avoid failures to source net/lib.sh" is
> a follow-up fix for tests inside the net/forwarding directory.
> 
> V2: Add 2114e833 "selftests: forwarding: Avoid failures to source net/lib.sh"
>     as suggested by Hangbin Liu.
> 
> Benjamin Poirier (1):
>   selftests: forwarding: Avoid failures to source net/lib.sh
> 
> Hangbin Liu (2):
>   selftests/net: add lib.sh
>   selftests/net: add variable NS_LIST for lib.sh
> 
>  tools/testing/selftests/net/Makefile          |  2 +-
>  tools/testing/selftests/net/forwarding/lib.sh | 52 +++++++--------
>  tools/testing/selftests/net/lib.sh            | 93 +++++++++++++++++++++++++++
>  3 files changed, 120 insertions(+), 27 deletions(-)
>  create mode 100644 tools/testing/selftests/net/lib.sh
> 
> -- 
> 2.7.4
> 

For the series

Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxx>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux