Re: [PATCH 5.10 260/317] powerpc/uaccess: Use asm goto for get_user when compiler supports it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 14, 2024 at 05:27:00PM +1000, Michael Ellerman wrote:
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> > 5.10-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> >
> > [ Upstream commit 5cd29b1fd3e8f2b45fe6d011588d832417defe31 ]
> >
> > clang 11 and future GCC are supporting asm goto with outputs.
> >
> > Use it to implement get_user in order to get better generated code.
> >
> > Note that clang requires to set x in the default branch of
> > __get_user_size_goto() otherwise is compliant about x not being
> > initialised :puzzled:
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/403745b5aaa1b315bb4e8e46c1ba949e77eecec0.1615398265.git.christophe.leroy@xxxxxxxxxx
> > Stable-dep-of: 50934945d542 ("powerpc/uaccess: Use YZ asm constraint for ld")
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  arch/powerpc/include/asm/uaccess.h | 55 ++++++++++++++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> 
> This is causing a build break. Please drop it.
> 
> There have been a lot of changes to uaccess.h since v5.10. I think
> rather than trying to pull in enough of them to allow backporting the
> recent uaccess fixes it'd be better to do a custom backport. I'll send
> one once I've done some build tests.

Now dropped, thanks!

greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux