On Thu, Jun 13, 2024 at 10:14:59PM +0200, Uwe Kleine-König wrote: > On Thu, Jun 13, 2024 at 01:31:14PM +0200, Greg Kroah-Hartman wrote: > > 4.19-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > [ Upstream commit 94eabddc24b3ec2d9e0ff77e17722a2afb092155 ] > > > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is ignored (apart > > from emitting a warning) and this typically results in resource leaks. > > > > To improve here there is a quest to make the remove callback return > > void. In the first step of this quest all drivers are converted to > > .remove_new(), which already returns void. Eventually after all drivers > > are converted, .remove_new() will be renamed to .remove(). > > > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > Link: https://lore.kernel.org/r/bc6b1caafa977346b33c1040d0f8e616bc0457bf.1712756364.git.u.kleine-koenig@xxxxxxxxxxxxxx > > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > > It's unclear to me why this patch is included. It doesn't seem to be a > dependency for a later patch?! Also .remove_new() only exists since v6.3-rc1~106^2~108 > and I'm not aware this was backported, too. So this probably results in > a build failure. Ditto for patch 27. Odd, both now dropped. greg k-h
