Hello Greg,
On Thu, Jun 13, 2024 at 10:32:35AM +0200, Greg KH wrote:
> On Thu, Jun 13, 2024 at 07:55:41AM +0200, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >
> > Using __exit for the remove function results in the remove callback being
> > discarded with CONFIG_MMC_DAVINCI=y. When such a device gets unbound (e.g.
> > using sysfs or hotplug), the driver is just removed without the cleanup
> > being performed. This results in resource leaks. Fix it by compiling in the
> > remove callback unconditionally.
> >
> > This also fixes a W=1 modpost warning:
> >
> > WARNING: modpost: drivers/mmc/host/davinci_mmc: section mismatch in
> > reference: davinci_mmcsd_driver+0x10 (section: .data) ->
> > davinci_mmcsd_remove (section: .exit.text)
> >
> > Fixes: b4cff4549b7a ("DaVinci: MMC: MMC/SD controller driver for DaVinci family")
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Link: https://lore.kernel.org/r/20240324114017.231936-2-u.kleine-koenig@xxxxxxxxxxxxxx
> > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > [ukleinek: Backport to v6.1.x]
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> > ---
> > drivers/mmc/host/davinci_mmc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> What is the git id of this commit in Linus's tree?
It's 55c421b364482b61c4c45313a535e61ed5ae4ea3.
Hmm, I was about to blame your instruction about not making me mention
that, but I think that would be wrong, as it included git cherry-pick
-x. Either the -x didn't make it into my cut-n-paste buffer or I dropped
that reference by mistake. Sorry, I will try to remember to include it
for future submissions.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature
