Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/15 17:54, Simon Wunderlich wrote:
Performing spectral scans on 5 GHz channels may result in PHY errors
sent by the hardware, even if DFS support is not enabled in the driver
(e.g. channel scanning or passive monitoring). In that case channels may
falsely get marked as 'unusable'. To fix that, only process radar PHY
errors when radar is explicitly enabled in the driver.

Hi Simon,

Not an ath9k expert, but I would think those channels would already be marked as unusable, because DFS is disabled in the driver. Or does this also affect 5G channels that do not require DFS.

Regards,
Arend

Cc: Stable<stable@xxxxxxxxxxxxxxx>  [v3.10+]
Reported-by: Mathias Kretschmer<mathias.kretschmer@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Simon Wunderlich<sw@xxxxxxxxxxxxxxxxxx>
---
  drivers/net/wireless/ath/ath9k/dfs.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath/ath9k/dfs.c
index 726271c..3d04905 100644
--- a/drivers/net/wireless/ath/ath9k/dfs.c
+++ b/drivers/net/wireless/ath/ath9k/dfs.c
@@ -152,6 +152,12 @@ void ath9k_dfs_process_phyerr(struct ath_softc *sc, void *data,
  		return;
  	}

+	if (!sc->hw->conf.radar_enabled) {
+		ath_dbg(common, DFS,
+			"Error: received radar phyerr while radar was disabled\n");
+		return;
+	}
+
  	datalen = rs->rs_datalen;
  	if (datalen == 0) {
  		DFS_STAT_INC(sc, datalen_discards);

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]