Hey,
Thanks for flagging this broonie.
On Tue, Jun 04, 2024 at 02:35:20PM +0100, Mark Brown wrote:
> I'm not seeing a test mail for v6.6.33-rc1 but it's in the stable-rc git
> and I'm seeing build failures in the KVM selftests for arm64 with it:
>
> /usr/bin/ld: /build/stage/build-work/kselftest/kvm/aarch64/vgic_init.o: in funct
> ion `test_v2_uaccess_cpuif_no_vcpus':
> /build/stage/linux/tools/testing/selftests/kvm/aarch64/vgic_init.c:388:(.text+0x
> 1234): undefined reference to `FIELD_PREP'
> /usr/bin/ld: /build/stage/linux/tools/testing/selftests/kvm/aarch64/vgic_init.c:
> 388:(.text+0x1244): undefined reference to `FIELD_PREP'
> /usr/bin/ld: /build/stage/linux/tools/testing/selftests/kvm/aarch64/vgic_init.c:
> 393:(.text+0x12a4): undefined reference to `FIELD_PREP'
> /usr/bin/ld: /build/stage/linux/tools/testing/selftests/kvm/aarch64/vgic_init.c:
> 393:(.text+0x12b4): undefined reference to `FIELD_PREP'
> /usr/bin/ld: /build/stage/linux/tools/testing/selftests/kvm/aarch64/vgic_init.c:
> 398:(.text+0x1308): undefined reference to `FIELD_PREP'
>
> due to 12237178b318fb3 ("KVM: selftests: Add test for uaccesses to
> non-existent vgic-v2 CPUIF") which was backported from
> 160933e330f4c5a13931d725a4d952a4b9aefa71.
Yeah, so this is likely because commit 0359c946b131 ("tools headers arm64:
Update sysreg.h with kernel sources") upstream got this test to indirectly
include bitfield.h. We should *not* backport the patch that fixes it,
though.
Let's either squash in the following, or just drop the offending patch
altogether.
--
Thanks,
Oliver
