Re: [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro
From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date: Mon, 3 Jun 2024 15:57:38 +0200
Cc: bpf@xxxxxxxxxxxxxxx, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Miguel Ojeda <ojeda@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <5416a38a194bb97930f5a2e672165e573b82857b.1717413886.git.Tony.Ambardar@gmail.com>

On Mon, Jun 3, 2024 at 2:16 PM Tony Ambardar <tony.ambardar@xxxxxxxxx> wrote:
>
> +#if __has_attribute(__retain__) && \
> +       (defined(CONFIG_LD_DEAD_CODE_DATA_ELIMINATION) || \
> +        defined(CONFIG_LTO_CLANG))

Since this attribute depends on the configuration, please move it to
`compiler_types.h` instead.

Cheers,
Miguel

Follow-Ups:
- Re: [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro
  - From: Tony Ambardar

References:
- [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro
  - From: Tony Ambardar

Prev by Date: Re: [PATCH 5.15 00/23] 5.15.160-rc1 review
Next by Date: [PATCH] drm/amd/display: prevent register access while in IPS
Previous by thread: [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro
Next by thread: Re: [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]

Powered by Linux