On Fri, May 31, 2024 at 4:16 AM Sasha Levin <sashal@xxxxxxxxxx> wrote: > > This is a note to let you know that I've just added the patch titled > > s390/vdso: Create .build-id links for unstripped vdso files > > to the 6.1-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > s390-vdso-create-.build-id-links-for-unstripped-vdso.patch > and it can be found in the queue-6.1 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > commit e5fcc928a0c3c2fe5e6e2c66a16b7d67334fac02 > Author: Jens Remus <jremus@xxxxxxxxxxxxx> > Date: Mon Apr 29 17:02:53 2024 +0200 > > s390/vdso: Create .build-id links for unstripped vdso files > > [ Upstream commit fc2f5f10f9bc5e58d38e9fda7dae107ac04a799f ] > > Citing Andy Lutomirski from commit dda1e95cee38 ("x86/vdso: Create > .build-id links for unstripped vdso files"): > > "With this change, doing 'make vdso_install' and telling gdb: > > set debug-file-directory /lib/modules/KVER/vdso > > will enable vdso debugging with symbols. This is useful for > testing, but kernel RPM builds will probably want to manually delete > these symlinks or otherwise do something sensible when they strip > the vdso/*.so files." > > Fixes: 4bff8cb54502 ("s390: convert to GENERIC_VDSO") I doubt this Fixes tag. I do not think this is a bug fix. Its prerequisites are not suitable for stable either. > Signed-off-by: Jens Remus <jremus@xxxxxxxxxxxxx> > Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > > diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst > index c477d17b0aa5b..a81ca735003e4 100644 > --- a/scripts/Makefile.vdsoinst > +++ b/scripts/Makefile.vdsoinst > @@ -21,7 +21,7 @@ $$(dest): $$(src) FORCE > $$(call cmd,install) > > # Some architectures create .build-id symlinks > -ifneq ($(filter arm sparc x86, $(SRCARCH)),) > +ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),) > link := $(install-dir)/.build-id/$$(shell $(READELF) -n $$(src) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p').debug > > __default: $$(link) -- Best Regards Masahiro Yamada