Hi Sergey,
Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> 於 2024年5月28日 週二 下午4:36寫道：
>
> On 5/28/24 6:31 AM, Kuangyi Chiang wrote:
>
> > As described in commit c877b3b2ad5c ("xhci: Add reset on resume quirk for
> > asrock p67 host"), EJ188 have the same issue as EJ168, where completely
> > dies on resume. So apply XHCI_RESET_ON_RESUME quirk to EJ188 as well.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Kuangyi Chiang <ki.chiang65@xxxxxxxxx>
> > ---
> > Changes in v2:
> > - Porting to latest release
> >
> > drivers/usb/host/xhci-pci.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index c040d816e626..b47d57d80b96 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> [...]
> > @@ -395,6 +396,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> > xhci->quirks |= XHCI_RESET_ON_RESUME;
> > xhci->quirks |= XHCI_BROKEN_STREAMS;
> > }
> > + if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> > + pdev->device == PCI_DEVICE_ID_EJ188) {
> > + xhci->quirks |= XHCI_RESET_ON_RESUME;
> > + }
>
> You don't need {} around a single statement, according to CodingStyle.
>
> [...]
>
> MBR, Sergey
Got it, I'll modify it and resend patches.
Thanks,
Kuangyi Chiang
