Re: [PATCH v2] crypto: arm64: use simd_skcipher_create() when registering aes internal algs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 22, 2024 at 06:18:54AM +0200, Greg KH wrote:
> On Wed, May 22, 2024 at 01:58:37PM +1000, Liam Kearney wrote:
> > The arm64 crypto drivers duplicate driver names when adding simd
> > variants, which after backported commit 27016f75f5ed ("crypto: api -
> > Disallow identical driver names"), causes an error that leads to the
> > aes algs not being installed. On weaker processors this results in hangs
> > due to falling back to SW crypto.
> 
> But that commit has already been reverted in the stable releases, right?
>

Ah yes, my apologies, I seem to have missed the revert. I've been away
for a few weeks, and this was just bumping the submission I made at the
beginning of May.

In that case, feel free to ignore this.

> > Use simd_skcipher_create() as it will properly namespace the new algs.
> > This issue does not exist in mainline/latest (and stable v6.1+) as the
> > driver has been refactored to remove the simd algs from this code path.
> > 
> > Fixes: 27016f75f5ed ("crypto: api - Disallow identical driver names")
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Liam Kearney <liam.kearney@xxxxxxxxxxxxx>
> 
> What kernel tree(s) are you thinking this needs to go to?
> 
> thanks,
> 
> greg k-h

It would be any pre 6.x, so 4.19, 5.4, 5.10, 5.15
But no need now since offending has been reverted.

(group replying for posterity)

Thanks,
Liam Kearney




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux