On Sun, May 19, 2024 at 05:38:24AM -0300, Val Packett wrote: > > > On Sun, May 19 2024 at 09:59:47 +02:00:00, Greg KH > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > > > On the RK3066, there is a bit that must be cleared on flush, > > > otherwise > > > we do not get display output (at least for RGB). > > > > What commit id does this fix? > > I guess: f4a6de855e "drm: rockchip: vop: add rk3066 vop definitions" ? Great, can you add a Fixes: tag when you resend these? > But similar changes like: > 742203cd "drm: rockchip: add missing registers for RK3066" > 8d544233 "drm/rockchip: vop: Add directly output rgb feature for px30" > did not have any "Fixes" reference. Just because people didn't properly tag things in the past, doesn't mean you should perpetuate that problem :) thanks, greg k-h
