Re: [PATCH v3] x86/tools: fix line number reported for malformed lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Commit 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > included symbol lines in the post-processed objdump output consumed by
> > the insn decoder test. This broke the `instuction lines == total lines`
> > property that `insn_decoder_test.c` relied upon to print the offending
> > line's number in error messages. This has the consequence that the line
> > number reported on a test failure is unreated to, and much smaller than,
> > the line that actually caused the problem.
> >
> > Add a new variable that counts the combined (insn+symbol) line count and
> > report this in the error message.
>
> This looks good to me. Thanks!
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks!

So what is the status on this one? Is there someone here who can take it
through their tree s.t. it might make it into 6.10-rc1 or 6.11-rc1?

	- Best Valentin

>
> >
> > Fixes: 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> > Tested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> > Reported-by: John Baublitz <john.m.baublitz@xxxxxxxxx>
> > Debugged-by: John Baublitz <john.m.baublitz@xxxxxxxxx>
> > Signed-off-by: Valentin Obst <kernel@xxxxxxxxxxxxxxx>
>
> --
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux