On 5/15/24 02:30, Kirill A. Shutemov wrote: >> nit: Perhaps this function can be put in the first patch and the description >> there be made more generic, something along the lines of "introduce >> functions for tdg_rd/tdg_wr" ? > A static function without an user will generate a build warning. I don't > think it is good idea. OK, so stick a __maybe_unused on it when you define it and remove it on first use.