On Tue, May 14, 2024 at 07:36:24PM -0500, Martin Faltesek wrote: > Build failure on arm: > > In file included from drivers/iommu/mtk_iommu_v1.c:22: > drivers/iommu/mtk_iommu_v1.c:579:25: error: 'mtk_iommu_v1_of_ids' > undeclared here (not in a function); did you mean 'mtk_iommu_of_ids'? > 579 | MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids); > | ^~~~~~~~~~~~~~~~~~~ > ./include/linux/module.h:244:15: note: in definition of macro > 'MODULE_DEVICE_TABLE' > 244 | extern typeof(name) __mod_##type##__##name##_device_table > \ > | ^~~~ > ./include/linux/module.h:244:21: error: > '__mod_of__mtk_iommu_v1_of_ids_device_table' aliased to undefined > symbol 'mtk_iommu_v1_of_ids' > 244 | extern typeof(name) __mod_##type##__##name##_device_table > \ > | ^~~~~~ > drivers/iommu/mtk_iommu_v1.c:579:1: note: in expansion of macro > 'MODULE_DEVICE_TABLE' > 579 | MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids); > | ^~~~~~~~~~~~~~~~~~~ > make[2]: *** [scripts/Makefile.build:289: drivers/iommu/mtk_iommu_v1.o] Error 1 > make[1]: *** [scripts/Makefile.build:552: drivers/iommu] Error 2 > > This is from patch: > > bce893a92324 krzk@xxxxxxxxxx 2024-05-14 iommu: mtk: fix > module autoloading > > +MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids); > > should be, I think: > > +MODULE_DEVICE_TABLE(of, mtk_iommu_of_ids); > Good catch, now fixed up. I'll push out a -rc2 with this in it. greg k-h
