This is a note to let you know that I've just added the patch titled
ncpfs: return proper error from NCP_IOC_SETROOT ioctl
to the 3.17-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ncpfs-return-proper-error-from-ncp_ioc_setroot-ioctl.patch
and it can be found in the queue-3.17 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From a682e9c28cac152e6e54c39efcf046e0c8cfcf63 Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 10 Dec 2014 15:52:22 -0800
Subject: ncpfs: return proper error from NCP_IOC_SETROOT ioctl
From: Jan Kara <jack@xxxxxxx>
commit a682e9c28cac152e6e54c39efcf046e0c8cfcf63 upstream.
If some error happens in NCP_IOC_SETROOT ioctl, the appropriate error
return value is then (in most cases) just overwritten before we return.
This can result in reporting success to userspace although error happened.
This bug was introduced by commit 2e54eb96e2c8 ("BKL: Remove BKL from
ncpfs"). Propagate the errors correctly.
Coverity id: 1226925.
Fixes: 2e54eb96e2c80 ("BKL: Remove BKL from ncpfs")
Signed-off-by: Jan Kara <jack@xxxxxxx>
Cc: Petr Vandrovec <petr@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/ncpfs/ioctl.c | 1 -
1 file changed, 1 deletion(-)
--- a/fs/ncpfs/ioctl.c
+++ b/fs/ncpfs/ioctl.c
@@ -447,7 +447,6 @@ static long __ncp_ioctl(struct inode *in
result = -EIO;
}
}
- result = 0;
}
mutex_unlock(&server->root_setup_lock);
Patches currently in stable-queue which might be from jack@xxxxxxx are
queue-3.17/isofs-fix-infinite-looping-over-ce-entries.patch
queue-3.17/ncpfs-return-proper-error-from-ncp_ioc_setroot-ioctl.patch
queue-3.17/udf-verify-i_size-when-loading-inode.patch
queue-3.17/udf-check-component-length-before-reading-it.patch
queue-3.17/udf-verify-symlink-size-before-loading-it.patch
queue-3.17/isofs-fix-unchecked-printing-of-er-records.patch
queue-3.17/f2fs-fix-possible-data-corruption-in-f2fs_write_begin.patch
queue-3.17/udf-check-path-length-when-reading-symlink.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html