On Thu, May 9, 2024 at 3:34 PM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > regulator_get() may sometimes be called more than once for the same > consumer device, something which before commit dbe954d8f163 ("regulator: > core: Avoid debugfs: Directory ... already present! error") resulted in > errors being logged. > > A couple of recent commits broke the handling of such cases so that > attributes are now erroneously created in the debugfs root directory the > second time a regulator is requested and the log is filled with errors > like: > > debugfs: File 'uA_load' in directory '/' already present! > debugfs: File 'min_uV' in directory '/' already present! > debugfs: File 'max_uV' in directory '/' already present! > debugfs: File 'constraint_flags' in directory '/' already present! > > on any further calls. > > Fixes: 2715bb11cfff ("regulator: core: Fix more error checking for debugfs_create_dir()") > Fixes: 08880713ceec ("regulator: core: Streamline debugfs operations") > Cc: stable@xxxxxxxxxxxxxxx > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> FTR, Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds