On Mon, Apr 29, 2024 at 10:10:40AM -0700, Tony Nguyen wrote: > From: Vitaly Lifshits <vitaly.lifshits@xxxxxxxxx> > > This is a partial revert of commit 6dbdd4de0362 ("e1000e: Workaround > for sporadic MDI error on Meteor Lake systems"). The referenced commit > used usleep_range inside the PHY access routines, which are sometimes > called from an atomic context. This can lead to a kernel panic in some > scenarios, such as cable disconnection and reconnection on vPro systems. > > Solve this by changing the usleep_range calls back to udelay. > > Fixes: 6dbdd4de0362 ("e1000e: Workaround for sporadic MDI error on Meteor Lake systems") > Cc: stable@xxxxxxxxxxxxxxx > Reported-by: Jérôme Carretero <cJ@xxxxxxxxxxx> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218740 > Closes: https://lore.kernel.org/lkml/a7eb665c74b5efb5140e6979759ed243072cb24a.camel@xxxxxxxxxxx/ > Co-developed-by: Sasha Neftin <sasha.neftin@xxxxxxxxx> > Signed-off-by: Sasha Neftin <sasha.neftin@xxxxxxxxx> > Signed-off-by: Vitaly Lifshits <vitaly.lifshits@xxxxxxxxx> > Tested-by: Dima Ruinskiy <dima.ruinskiy@xxxxxxxxx> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>