On Sun, Apr 28, 2024 at 10:28:42AM +0200, Jan Kiszka wrote: > From: Christian Marangi <ansuelsmth@xxxxxxxxx> > > [ Upstream commit 08e23d05fa6dc4fc13da0ccf09defdd4bbc92ff4 ] > > Fix buffer overflow in trans_stat_show(). > > Convert simple snprintf to the more secure scnprintf with size of > PAGE_SIZE. > > Add condition checking if we are exceeding PAGE_SIZE and exit early from > loop. Also add at the end a warning that we exceeded PAGE_SIZE and that > stats is disabled. > > Return -EFBIG in the case where we don't have enough space to write the > full transition table. > > Also document in the ABI that this function can return -EFBIG error. > > Link: https://lore.kernel.org/all/20231024183016.14648-2-ansuelsmth@xxxxxxxxx/ > Cc: stable@xxxxxxxxxxxxxxx > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218041 > Fixes: e552bbaf5b98 ("PM / devfreq: Add sysfs node for representing frequency transition information.") > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> > --- > > Original found by someone at Nvidia. But this backport is based on the > 5.15 commit (796d3fad8c35ee9df9027899fb90ceaeb41b958f) where only a > conflict in sysfs-class-devfreq needed manual resolution. Now queued up, thanks. greg k-h
