On Tue, Apr 23, 2024 at 08:25:46PM +0000, RD Babiera wrote:
> tcpm_queue_vdm_unlocked queues VDMs over SOP regardless of input
> parameter tx_sop_type. Fix tcpm_queue_vdm() call.
>
> Fixes: 7e7877c55eb1 ("usb: typec: tcpm: add alt mode enter/exit/vdm support for sop'")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: RD Babiera <rdbabiera@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> Patch applies starting at 6.9 tree.
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index c26fb70c3ec6..3f38e7c7d13f 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1565,7 +1565,7 @@ static void tcpm_queue_vdm_unlocked(struct tcpm_port *port, const u32 header,
> const u32 *data, int cnt, enum tcpm_transmit_type tx_sop_type)
> {
> mutex_lock(&port->lock);
> - tcpm_queue_vdm(port, header, data, cnt, TCPC_TX_SOP);
> + tcpm_queue_vdm(port, header, data, cnt, tx_sop_type);
> mutex_unlock(&port->lock);
> }
>
>
> base-commit: 684e9f5f97eb4b7831298ffad140d5c1d426ff27
> --
> 2.44.0.769.g3c40516874-goog
--
heikki
