Re: [PATCH 6.1 056/141] ARM: OMAP2+: pdata-quirks: stop including wl12xx.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 23, 2024 at 02:38:44PM -0700, Greg Kroah-Hartman wrote:
> 6.1-stable review patch.  If anyone has any objections, please let me know.
> 

But why?

Greg, if you ask for a stable review of a patch that has not been
explicitly tagged for stable shouldn't it be on you to provide
justification why you believe it is needed in stable? Does it fix a
grave bug? A regression? Users need it to make their new hardware be
recognized?

> ------------------
> 
> From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> 
> [ Upstream commit e14e4c933e0047653f835e30d7d740ebb2a530cc ]
> 
> As of commit 2398c41d6432 ("omap: pdata-quirks: remove openpandora
> quirks for mmc3 and wl1251") the code no longer creates an instance of
> wl1251_platform_data, so there is no need for including this header.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20221109224250.2885119-1-dmitry.torokhov@xxxxxxxxx
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  arch/arm/mach-omap2/pdata-quirks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
> index 9deba798cc919..baba73fd6f11e 100644
> --- a/arch/arm/mach-omap2/pdata-quirks.c
> +++ b/arch/arm/mach-omap2/pdata-quirks.c
> @@ -10,7 +10,6 @@
>  #include <linux/init.h>
>  #include <linux/kernel.h>
>  #include <linux/of_platform.h>
> -#include <linux/wl12xx.h>
>  #include <linux/mmc/card.h>
>  #include <linux/mmc/host.h>
>  #include <linux/power/smartreflex.h>
> -- 
> 2.43.0
> 
> 

Thanks.

-- 
Dmitry




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux