Hi, On Mon, Apr 22, 2024 at 9:38 AM Daniel Thompson <daniel.thompson@xxxxxxxxxx> wrote: > > Currently when the current line should be removed from the display > kdb_read() uses memset() to fill a temporary buffer with spaces. > The problem is not that this could be trivially implemented using a > format string rather than open coding it. The real problem is that > it is possible, on systems with a long kdb_prompt_str, to write pas nit: s/pas/past > the end of the tmpbuffer. > > Happily, as mentioned above, this can be trivially implemented using a > format string. Make it so! > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > --- > kernel/debug/kdb/kdb_io.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
