Re: [PATCH 1/2] USB: serial: option: add Lonsung U8300/U9300 product Update the USB serial option driver to support Longsung U8300/U9300.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 02, 2024 at 03:09:12PM +0700, Lars Melin wrote:
> On 2024-04-02 14:34, Coia Prant wrote:

You're Subject is missing two newline characters to separate the commit
summary from the commit message.

> > ID 1c9e:9b05 OMEGA TECHNOLOGY (U8300)
> > ID 1c9e:9b3c OMEGA TECHNOLOGY (U9300)
> > 
> > U8300
> >   /: Bus
> >      |__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=option, 480M (Debug)
> >          ID 1c9e:9b05 OMEGA TECHNOLOGY
> >      |__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
> >          ID 1c9e:9b05 OMEGA TECHNOLOGY
> >      |__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
> >          ID 1c9e:9b05 OMEGA TECHNOLOGY
> >      |__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
> >          ID 1c9e:9b05 OMEGA TECHNOLOGY
> >      |__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
> >          ID 1c9e:9b05 OMEGA TECHNOLOGY
> >      |__ Port 1: Dev 3, If 5, Class=Vendor Specific Class, Driver=, 480M (ADB)
> >          ID 1c9e:9b05 OMEGA TECHNOLOGY

Could please use the more condensed output of the usb-devices command
(for both devices) which is better suited for a commit message?

> Reviewed-by Lars Melin (larsm17@xxxxxxxxx
> 
> added the maintainer to the recipient list

Thanks for reviewing, Lars.

Coia, you can include Lars's Reviewed-by tag when you send a v2.

Johan




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux