On Apr 10, 2024 / 23:39, Saranya Muruganandam wrote: > The BLKRRPART ioctl used to report errors such as EIO before we changed > the blkdev_reread_part() logic. > > Add a flag and capture the errors returned by bdev_disk_changed() > when the flag is set. Set this flag for the BLKRRPART path when we > want the errors to be reported when rereading partitions on the disk. > > Link: https://lore.kernel.org/all/20240320015134.GA14267@xxxxxx/ > Suggested-by: Christoph Hellwig <hch@xxxxxx> > Tested: Tested by simulating failure to the block device and will > propose a new test to blktests. > Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part") > Reported-by: Saranya Muruganandam <saranyamohan@xxxxxxxxxx> > Signed-off-by: Saranya Muruganandam <saranyamohan@xxxxxxxxxx> The change looks good to me. I also confirmed the fix with the new, corresponding blktests test case. Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
