On Thu, Apr 4, 2024 at 12:59 PM Kent Gibson <warthog618@xxxxxxxxx> wrote: > > On Thu, Apr 04, 2024 at 10:20:29AM +0200, Bartosz Golaszewski wrote: > > > > Now that I look at the actual patch, I don't really like it. We > > introduce a bug just to fix it a commit later. Such things have been > > frowned upon in the past. > > > > Let me shuffle the code a bit, I'll try to make it a bit more correct. > > > > The debounce_setup() oversight bug is the more severe, so it makes more > sense to me to fix it first. But then I my preferred solution would be > to pull the original patch and submit a corrected patch that merges all > three, so no bugs, but I assume that isn't an option. > Nah, let's not needlessly rebase it. Most I can do is merge the two but they are really functionally separate so I'd keep it as is in v2. Bart
