RE: [PATCH v2 1/2] Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> handler"
> 
> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984.
> 
> It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in an
> interrupt handler as the interrupt handler itself would be called in a process
> context if PREEMPT_RT is enabled. So revert the patch.
> 
> Cc: stable@xxxxxxxxxxxxxxx # for 6.8
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Acked-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
>  drivers/misc/mei/vsc-tp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> ecfb70cd057c..968a92a7425d 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)
> 
>  	atomic_inc(&tp->assert_cnt);
> 
> +	wake_up(&tp->xfer_wait);
> +
>  	return IRQ_WAKE_THREAD;
>  }
> 
> @@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void
> *data)  {
>  	struct vsc_tp *tp = data;
> 
> -	wake_up(&tp->xfer_wait);
> -
>  	if (tp->event_notify)
>  		tp->event_notify(tp->event_notify_context);
> 
> --
> 2.34.1






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux