On Tue, Apr 2, 2024, at 09:30, Ard Biesheuvel wrote:
> On Tue, 2 Apr 2024 at 10:19, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>>
>> On Mon, Apr 1, 2024, at 17:43, Greg Kroah-Hartman wrote:
>> > 6.8-stable review patch. If anyone has any objections, please let me know.
>>
>> I think we should not backport the feature removal, this was
>> intentionally done separately from the bugfix in 303d6da167dc
>> ("ARM: iwmmxt: Use undef hook to enable coprocessor for task")
>> that is indeed needed in stable kernels.
>>
>
> 303d6da167dc is not a bugfix - it moves the undef handling into C code
> for PJ4 but only for ARM not Thumb.
>
> Subsequently, 8bcba70cb5c22 removed the Thumb exception handling,
> leading to the regression.
>
> So without this fix, the Thumb case remains broken unless iwmmxt
> support is disabled in Kconfig.
>
>> It still makes sense for everyone to just turn iwmmxt support
>> off on pj4.
>>
>
> If that is deemed sufficient for stable kernels, then we can drop this
> backport. Otherwise, we need to do something else if this patch is not
> suitable for -stable
My mistake, I misremembered what you did in the end.
Let's keep this one in stable then.
Arnd
