On Mon, Mar 25, 2024 at 03:57:06AM +0000, Matthew Wilcox wrote: > On Mon, Mar 25, 2024 at 11:36:49AM +0800, Liu Shixin wrote: > > Hi, > > > > After backport commit c79c5a0a00a9 ("mm/memory-failure: check the mapcount of the precise page"), > > > > I got an error message as written on the patch. The problem can be fixed by the patch or just revert. > > > > Now I prefer to revert because I think it is related to folio and no impact in stable, or maybe I'm wrong. > > I checked out what is going wrong here, and Liu Shixin is correct. > > Commit c79c5a0a00a9 was incorrectly backported to v5.10 and > commit 70168fdc743b changees the page passed to try_to_unmap(). > It now passes the tail page, and should always have passed hpage. > Please apply the patch below to v5.10 (and any other trees that > c79c5a0a00a9 got backported to). All now queued up,t hanks. greg k-h