[PATCH v2] x86/tsc: Change Fast TSC calibration failed from error to warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Most users see this message when booting without knowning that it is of 
mostly no importance and that TSC calibration may have succeeded by another 
way.

As explained thoroufly by Paul Bolle in 2012 
(http://lkml.iu.edu//hypermail/linux/kernel/1209.3/00224.html), 
"Fast TSC calibration failed" should not be considered as an error since 
other calibration methods are being tried afterward. At most, those send a 
warning if they fail (not an error). So let's change the message from error 
to warning.

It should also fix bug 75971: fast tsc calibration failed on ubuntu 14.04 LTS

Tested on kernel 3.18.

v2: fixed comment.

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Alexandre Demers <alexandre.f.demers@xxxxxxxxx>

---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index b6025f9..5a22022 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -617,7 +617,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_warn("Fast TSC calibration failed\n");
 	return 0;
 
 success:
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]