Dave Hansen <dave.hansen@xxxxxxxxx> writes: > On 3/22/24 09:21, Steve Wahl wrote: >> Some systems have ACPI tables that don't include everything that needs >> to be mapped for a successful kexec. These systems rely on identity >> maps that include the full gigabyte surrounding any smaller region >> requested for kexec success. Without this, they fail to kexec and end >> up doing a full firmware reboot. >> >> So, reduce the use of GB pages only on systems where this is known to >> be necessary (specifically, UV systems). > > Isn't this called "buggy firmware"? > > I'd much rather add synthetic entries to the memory maps that have this > information than hack around it by assuming that things are within a > gigabyte. So this change is a partial revert of a change that broke kexec in existing configurations. To fix a regression that breaks kexec. I don't have enough to know which systems broke. So I don't know the difficulty in fixing systems. Dave do you know what synthetic entries need to be added to the memory maps to fix the regression? If not we should go with this and if we care enough we can add the synthetic entries later. Eric
