On Wed, Mar 13, 2024 at 05:54:10AM +0200, Dmitry Baryshkov wrote: > Fix several issues discovered while debugging UCSI implementation on > Qualcomm platforms (ucsi_glink). With these patches I was able to > get a working Type-C port managament implementation. Tested on SC8280XP > (Lenovo X13s laptop) and SM8350-HDK. > Dmitry Baryshkov (7): > usb: typec: ucsi: fix race condition in connection change ACK'ing > usb: typec: ucsi: acknowledge the UCSI_CCI_NOT_SUPPORTED > usb: typec: ucsi: make ACK_CC_CI rules more obvious > usb: typec: ucsi: allow non-partner GET_PDOS for Qualcomm devices > usb: typec: ucsi: limit the UCSI_NO_PARTNER_PDOS even further > usb: typec: ucsi: properly register partner's PD device > soc: qcom: pmic_glink: reenable UCSI on sc8280xp I just gave this series a quick spin on my X13s and it seems there are still some issues that needs to be resolved before merging at least the final patch in this series: [ 7.786167] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: unknown error 0 [ 7.786445] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: UCSI_GET_PDOS failed (-5) [ 7.883493] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: unknown error 0 [ 7.883614] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: UCSI_GET_PDOS failed (-5) [ 7.905194] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: unknown error 0 [ 7.905295] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: UCSI_GET_PDOS failed (-5) [ 7.913340] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: unknown error 0 [ 7.913409] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: UCSI_GET_PDOS failed (-5) I see these errors on boot both with and without my charger and ethernet device connected. I'm afraid I won't have to time to help debug this myself at least for another week. Johan
