> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Matthew Auld
> Sent: 21 March 2024 16:37
> To: intel-xe@xxxxxxxxxxxxxxxxxxxxx
> Cc: Das, Nirmoy <nirmoy.das@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx
> Subject: [PATCH] drm/xe/query: fix gt_id bounds check
>
> The user provided gt_id should always be less than the
> XE_MAX_GT_PER_TILE.
>
> Fixes: 7793d00d1bf5 ("drm/xe: Correlate engine and cpu timestamps with
> better accuracy")
> Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
> Cc: Nirmoy Das <nirmoy.das@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.8+
> ---
> drivers/gpu/drm/xe/xe_query.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_query.c
> b/drivers/gpu/drm/xe/xe_query.c index fcd8680d2ccc..df407d73e5f5 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -133,7 +133,7 @@ query_engine_cycles(struct xe_device *xe,
> return -EINVAL;
>
> eci = &resp.eci;
> - if (eci->gt_id > XE_MAX_GT_PER_TILE)
> + if (eci->gt_id >= XE_MAX_GT_PER_TILE)
Acked-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@xxxxxxxxx>
> return -EINVAL;
>
> gt = xe_device_get_gt(xe, eci->gt_id);
> --
> 2.44.0
