On Thu, 2024-03-07 at 09:51 -0800, Jakub Kicinski wrote: > LGTM, thanks! Minor nit picks for the tags, otherise: > > Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx> > Thanks! > On Thu, 7 Mar 2024 12:15:47 +0200 Dragos Tatulea wrote: > > Signed-off-by: Dragos Tatulea <dtatulea@xxxxxxxxxx> > > General guidance is to order tag chronologically, so: > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: (speaking of which, you need to add it, presumably point it at > the commit where skb->pp_recycle was added) > Reported-by: > Link / Closes: > your sign-off > Review tags > > > Reported-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@xxxxxxxxxxxxxxx> > > Tested-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@xxxxxxxxxxxxxxx> > > You can combine it as Reported-and-tested-by: > up to you > > > Reported-by: Ian Kumlien <ian.kumlien@xxxxxxxxx> > > Closes: https: //lore.kernel.org/netdev/CAA85sZvvHtrpTQRqdaOx6gd55zPAVsqMYk_Lwh4Md5knTq7AyA@xxxxxxxxxxxxxx > > A space sneaked into the link. > > > Cc: stable@xxxxxxxxxxxxxxx > > Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx> > > Change-Id: I3d2744e1abb33a694a8f49e07f913724a0f8871a > > Change-Id's gotta go. Fixed tags in v2. Thanks for explaining the tag order. It was never really clear to me. Thanks, Dragos
