Hi Greg, Thanks for the review. On 3/6/24 06:10, Greg KH wrote: > External email: Use caution opening links or attachments > > > On Wed, Mar 06, 2024 at 12:11:22AM +0800, Wayne Chang wrote: >> This commit resolves an issue in the tegra-xudc USB gadget driver that >> incorrectly fetched USB3 PHY instances. The problem stemmed from the >> assumption of a one-to-one correspondence between USB2 and USB3 PHY >> names and their association with physical USB ports in the device tree. >> >> Previously, the driver associated USB3 PHY names directly with the USB3 >> instance number, leading to mismatches when mapping the physical USB >> ports. For instance, if using USB3-1 PHY, the driver expect the >> corresponding PHY name as 'usb3-1'. However, the physical USB ports in >> the device tree were designated as USB2-0 and USB3-0 as we only have >> one device controller, causing a misalignment. >> >> This commit rectifies the issue by adjusting the PHY naming logic. >> Now, the driver correctly correlates the USB2 and USB3 PHY instances, >> allowing the USB2-0 and USB3-1 PHYs to form a physical USB port pair >> while accurately reflecting their configuration in the device tree by >> naming them USB2-0 and USB3-0, respectively. >> >> The change ensures that the PHY and PHY names align appropriately, >> resolving the mismatch between physical USB ports and their associated >> names in the device tree. >> >> Fixes: b4e19931c98a ("usb: gadget: tegra-xudc: Support multiple device modes") >> Cc: stable@xxxxxxxxxxxxxxx > You mark patch 2/2 for stable, but not patch 1/2? That's not going to > work well, is it? :( Yes, sorry about that. I'll update in the next patchset. > thanks, > > greg k-h > thanks, Wayne.