On Mon, 04 Mar 2024 10:29:44 -0800, Bart Van Assche wrote: > Patch "fs/aio: Make io_cancel() generate completions again" is based on the > assumption that calling kiocb->ki_cancel() does not complete R/W requests. > This is incorrect: the two drivers that call kiocb_set_cancel_fn() callers > set a cancellation function that calls usb_ep_dequeue(). According to its > documentation, usb_ep_dequeue() calls the completion routine with status > -ECONNRESET. Hence this revert. > > [...] I'm not enthusiastic about how we handled this. There was apparently more guesswork involved than anything else and I had asked multiple times whether that patch is really required. So please, let's be more careful going forward. --- Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] Revert "fs/aio: Make io_cancel() generate completions again" https://git.kernel.org/vfs/vfs/c/d435ca3d38eb
