On Thu, Feb 29, 2024 at 12:35:23AM +0530, Vamshi Gajjela wrote: > Ensure consistency in spmi_controller pointers between > spmi_controller_remove/put and driver spmi_del_controller functions. > The former requires a pointer to struct spmi_controller, while the > latter passes a pointer of struct spmi_controller_dev, leading to a > "Null pointer exception". > > Signed-off-by: Vamshi Gajjela <vamshigajjela@xxxxxxxxxx> > Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver") > Cc: stable@xxxxxxxxxxxxxxx > --- > v2: > - Split into two separate patches > - add Fixes and Cc stable You need to mark this patch more clearly as a stable backport (e.g. using a "[PATCH-stable]" prefix), and explain that the corresponding issue has already been fixed upstream by commits: 490d88ef548d ("spmi: hisi-spmi-controller: Use devm_spmi_controller_add()") ffdfbafdc4f4 ("spmi: Use devm_spmi_controller_alloc()") but that those commits (and their dependencies) are too intrusive to backport. Johan