5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cyril Hrubis <chrubis@xxxxxxx> commit c1fc6484e1fb7cc2481d169bfef129a1b0676abe upstream. The sched_rr_timeslice can be reset to default by writing value that is <= 0. However after reading from this file we always got the last value written, which is not useful at all. $ echo -1 > /proc/sys/kernel/sched_rr_timeslice_ms $ cat /proc/sys/kernel/sched_rr_timeslice_ms -1 Fix this by setting the variable that holds the sysctl file value to the jiffies_to_msecs(RR_TIMESLICE) in case that <= 0 value was written. Signed-off-by: Cyril Hrubis <chrubis@xxxxxxx> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx> Reviewed-by: Petr Vorel <pvorel@xxxxxxx> Acked-by: Mel Gorman <mgorman@xxxxxxx> Tested-by: Petr Vorel <pvorel@xxxxxxx> Cc: Mahmoud Adam <mngyadam@xxxxxxxxxx> Link: https://lore.kernel.org/r/20230802151906.25258-3-chrubis@xxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- kernel/sched/rt.c | 3 +++ 1 file changed, 3 insertions(+) --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2804,6 +2804,9 @@ int sched_rr_handler(struct ctl_table *t sched_rr_timeslice = sysctl_sched_rr_timeslice <= 0 ? RR_TIMESLICE : msecs_to_jiffies(sysctl_sched_rr_timeslice); + + if (sysctl_sched_rr_timeslice <= 0) + sysctl_sched_rr_timeslice = jiffies_to_msecs(RR_TIMESLICE); } mutex_unlock(&mutex);
