Re: [PATCH] USB: xhci: Reset a halted endpoint immediately when we encounter a stall.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Dec 05, 2014 at 09:47:30AM -0800, Greg KH wrote:
> On Fri, Dec 05, 2014 at 10:34:06AM -0600, Felipe Balbi wrote:
> > From: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> > 
> > commit 8e71a322fdb127814bcba423a512914ca5bc6cf5 upstream.
> > 
> > If a device is halted and reuturns a STALL, then the halted endpoint
> > needs to be cleared both on the host and device side. The host
> > side halt is cleared by issueing a xhci reset endpoint command. The device side
> > is cleared with a ClearFeature(ENDPOINT_HALT) request, which should
> > be issued by the device driver if a URB reruen -EPIPE.
> > 
> > Previously we cleared the host side halt after the device side was cleared.
> > To make sure the host side halt is cleared in time we want to issue the
> > reset endpoint command immedialtely when a STALL status is encountered.
> > 
> > Otherwise we end up not following the specs and not returning -EPIPE
> > several times in a row when trying to transfer data to a halted endpoint.
> > 
> > Fixes: bcef3fd (USB: xhci: Handle errors that cause endpoint halts.)
> > Tested-by: Felipe Balbi <balbi@xxxxxx>
> > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> > 
> > Mathias, can you confirm this backport is correct ? Thank you
> 
> Backport for what kernel release?

should've mentioned: 3.14

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]