Re: [PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> writes:

> Add regulator_has_full_constraints() call to corgi board file to let
> regulator core know that we do not have any additional regulators left.
> This lets it substitute unprovided regulators with dummy ones.
>
> This fixes the following warnings that can be seen on corgi if
> regulators are enabled:
>
> ads7846 spi1.0: unable to get regulator: -517
> spi spi1.0: Driver ads7846 requests probe deferral
> wm8731 0-001b: Failed to get supply 'AVDD': -517
> wm8731 0-001b: Failed to request supplies: -517
> wm8731 0-001b: ASoC: failed to probe component -517
> corgi-audio corgi-audio: ASoC: failed to instantiate card -517
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> ---
>  arch/arm/mach-pxa/corgi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c
> index 06022b2..89f790d 100644
> --- a/arch/arm/mach-pxa/corgi.c
> +++ b/arch/arm/mach-pxa/corgi.c
> @@ -26,6 +26,7 @@
>  #include <linux/i2c.h>
>  #include <linux/i2c/pxa-i2c.h>
>  #include <linux/io.h>
> +#include <linux/regulator/machine.h>
>  #include <linux/spi/spi.h>
>  #include <linux/spi/ads7846.h>
>  #include <linux/spi/corgi_lcd.h>
> @@ -752,6 +753,8 @@ static void __init corgi_init(void)
>  		sharpsl_nand_partitions[1].size = 53 * 1024 * 1024;
>  
>  	platform_add_devices(devices, ARRAY_SIZE(devices));
> +
> +	regulator_has_full_constraints();
>  }
>  
>  static void __init fixup_corgi(struct tag *tags, char **cmdline)

Added Mark for review, as I was thinking regulator_has_full_constraints() was to
be used to disable unused regulators, a bit like in the clock framework, rather
than provide a way to provide automatically dummy regulators.

If Mark acks, I'll take the serie.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]