On 2/19/24 10:30, Vladimir Oltean wrote: > Hi Sean, > > On Thu, Feb 15, 2024 at 11:23:26AM -0500, Sean Anderson wrote: >> smp_call_function_single disables IRQs when executing the callback. To >> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. >> This is already done by qman_update_cgr and qman_delete_cgr; fix the >> other lockers. >> >> Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()") >> CC: stable@xxxxxxxxxxxxxxx >> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx> >> Reviewed-by: Camelia Groza <camelia.groza@xxxxxxx> >> Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> >> --- >> I got no response the first time I sent this, so I am resending to net. >> This issue was introduced in a series which went through net, so I hope >> it makes sense to take it via net. >> >> [1] https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2flore.kernel.org%2flinux%2darm%2dkernel%2f20240108161904.2865093%2d1%2dsean.anderson%40seco.com%2f&umid=75622bdd-3d90-45a2-89a9-60921f1f3189&auth=d807158c60b7d2502abde8a2fc01f40662980862-0625a208f4f6c241a307b4380763ba50532758bf >> >> (no changes since v3) >> >> Changes in v3: >> - Change blamed commit to something more appropriate >> >> Changes in v2: >> - Fix one additional call to spin_unlock > > Leo Li (Li Yang) is no longer with NXP. Until we figure out within NXP > how to continue with the maintainership of drivers/soc/fsl/, yes, please > continue to submit this series to 'net'. I would also like to point > out to Arnd that this is the case. > > Arnd, a large portion of drivers/soc/fsl/ is networking-related > (dpio, qbman). Would it make sense to transfer the maintainership > of these under the respective networking drivers, to simplify the > procedures? > > Also, your patches are whitespace-damaged. They do not apply to the > kernel, and patchwork shows this as well. > https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2fpatchwork.kernel.org%2fproject%2fnetdevbpf%2fpatch%2f20240215162327.3663092%2d1%2dsean.anderson%40seco.com%2f&umid=75622bdd-3d90-45a2-89a9-60921f1f3189&auth=d807158c60b7d2502abde8a2fc01f40662980862-ec9df03b11ef3e6b48a457ca5469e0b20c4b0439 > > Please repost with this fixed. Hm, I used the same method I have in the past (git send-email). But I guess something is converting my tabs to spaces? Maybe it is related to the embedded world advertisement... Maybe the solution is to get a kernel.org email... --Sean [Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>