On Tue, Feb 06, 2024 at 05:22:15PM +0530, Joy Chakraborty wrote: > > > Userspace will see a false error with nvmem cell reads from > > > nvmem_cell_attr_read() in current code, which should be fixed on > > > returning 0 for success. > > > > So maybe fix this all up to allow the read to return the actual amount > > read? That feels more "correct" to me. > > > > If I change the behavior of the nvmem_reg_read_t callback to negative > for error and number of bytes actually read for success then, other > than the core driver I would also have to change all the > nvmem-provider drivers. > Is it okay to do so ? Sure, why not? That seems like the correct fix to me, right? thanks, greg k-h