Re: [PATCH 6.7 427/641] io_uring: dont check iopoll if request completes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29. 01. 24, 14:58, Jens Axboe wrote:
On 1/29/24 12:34 AM, Jiri Slaby wrote:
On 29. 01. 24, 7:44, Jiri Slaby wrote:
On 23. 01. 24, 0:55, Greg Kroah-Hartman wrote:
6.7-stable review patch.  If anyone has any objections, please let me know.

Hi,

6.7.2 fails in liburing tests (both x64 and x86-32 lib on x64 kernel):
[  115s] Tests failed (5): <fd-pass.t> <msg-ring-overflow.t> <pipe-bug.t> <poll-race-mshot.t> <reg-hint.t>

I cannot reproduce locally, that happens only in openSUSE build machinery (the errors are transient, the links might not be valid in the future):
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/liburing/standard/i586
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/liburing/standard/x86_64

So I cannot tell if 6.8-rc is affected.

I suspect one of the 6.7.2 uring changes:
e24bf5b47a57 io_uring: adjust defer tw counting
22eed9134509 io_uring: ensure local task_work is run on wait timeout
ba8d8a8a36b2 io_uring/rw: ensure io->bytes_done is always initialized
d413a342275d io_uring: don't check iopoll if request completes

It looks like EINVAL is received unexpectedly (see below). Any ideas?

Forget about this. The build service is currently broken and is using
5.14 kernel instead of 6.7.2.

Ah that makes sense, the tests should work (in the sense that they
should not fail) on eg 5.15-stable, but I guess the 5.14 kernel is
something else entirely? Most of them would return 77 on older kernels
where a specific feature is missing, but eg pipe-bug.t should definitely
run and pass on older kernels.

It's SUSE's 5.14, so 5.14 with this many patches (45k+):
https://raw.githubusercontent.com/openSUSE/kernel-source/SLE15-SP5/series.conf

I am not sure it is supposed to be working in there too. But maybe we are missing some fixes on the top of the backported patches...

FWIW 6.7.2 was fine after all.

thanks,
--
js
suse labs





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux