On Tue, Jan 30, 2024 at 12:06:32PM +0800, Dawei Li wrote:
> For data structures needs cpu_to_le* conversion, its prototype needs to
> be declared with __le* explicitly.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@xxxxxxxxx/
> Signed-off-by: Dawei Li <dawei.li@xxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> ---
> drivers/misc/eeprom/idt_89hpesx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index d807d08e2614..327afb866b21 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -129,7 +129,7 @@ struct idt_smb_seq {
> struct idt_eeprom_seq {
> u8 cmd;
> u8 eeaddr;
> - u16 memaddr;
> + __le16 memaddr;
> u8 data;
> } __packed;
>
> @@ -141,8 +141,8 @@ struct idt_eeprom_seq {
> */
> struct idt_csr_seq {
> u8 cmd;
> - u16 csraddr;
> - u32 data;
> + __le16 csraddr;
> + __le32 data;
> } __packed;
>
> /*
Declaring them this way is nice, but this doesn't actually "fix"
anything at all as no code is actually changed.
So how is ths a bugfix? How does this patch do anything?
confused,
greg k-h
