Re: [PATCH 2/4] arm64: dts: qcom: sm8550-mtp: correct WCD9385 TX port mapping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/01/2024 11:47, Konrad Dybcio wrote:


On 1/25/24 11:43, Krzysztof Kozlowski wrote:
On 25/01/2024 10:59, Konrad Dybcio wrote:


On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact
it is offset by one.  Correct it to fix recording via analogue
microphones.

The change is based on QRD8550 and should be correct here as well, but
was not tested on MTP8550.

Would this not be codec-and-not-board-specific, anyway?

Yes, indeed, it should be.

Should we move this to the driver and drop the then-uselesss
dt property?

Actually it's codec-and-soc specific, so I'm against dropping this.

On the sc8280xp & sc7280 it requires a different mapping because the
TX macro changed the way to map the soundwire channels since (at least) SM8450.

Neil


Konrad






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux